Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] 🐛 Improve clustermodule existence check #2554

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[release-1.8] 🐛 Improve clustermodule existence check #2554

merged 1 commit into from
Dec 14, 2023

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Dec 13, 2023

Cherry-pick of #2535 for release 1.8

@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2023
@rikatz rikatz force-pushed the cherrypick-2535-release18 branch from a6f9887 to 0604ac0 Compare December 13, 2023 19:28
@rikatz rikatz changed the title [Release-1.8] Cherry-pick of #2535 [Release-1.8] 🐛 Cherry-pick of #2535 Dec 13, 2023
@rikatz rikatz changed the title [Release-1.8] 🐛 Cherry-pick of #2535 [Release-1.8] 🐛 Improve clustermodule existence check Dec 13, 2023
@rikatz rikatz changed the title [Release-1.8] 🐛 Improve clustermodule existence check [Release-1.8] 🐛 Improve clustermodule existence check Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2023 •
edited
Loading

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-release-1-8 0604ac0 link false /test pull-cluster-api-provider-vsphere-apidiff-release-1-8

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rikatz
Copy link
Contributor Author

rikatz commented Dec 13, 2023

/assign @sbueringer

@chrischdi @sbueringer I will try to make the cherry-pick for 1.7 tomorrow, just waiting this one to pass to make sure I didn't broke anything between releases

@sbueringer sbueringer changed the title [Release-1.8] 🐛 Improve clustermodule existence check [release-1.8] 🐛 Improve clustermodule existence check Dec 14, 2023
@sbueringer
Copy link
Member

/lgtm

I'm fine either way regarding the public func

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4a4878d5d9e55282ff755a143683409e3597630

@chrischdi
Copy link
Member

If stefans okay then I am too

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1b6b682 into kubernetes-sigs:release-1.8 Dec 14, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@rikatz @k8s-ci-robot @sbueringer @chrischdi